evanfuchs Posted February 26, 2023 Share Posted February 26, 2023 @luckman212 here you go: https://pastebin.com/ru5eAA12 https://pastebin.com/eeruT0Xc Link to comment
luckman212 Posted February 26, 2023 Author Share Posted February 26, 2023 (edited) @oorbx and @evanfuchs - Can you try the latest version of the workflow (2.1.4) that I just published? I think the problem may have been that I previously had not enabled the "Keep File Lists" option in my Alfred preferences. With that on, I see that copying images sometimes results in a "File: xxx" type which was not previously handled by my workflow. This is a first attempt at handling both types within the same script filter. Please let me know if it works for you. Edited February 27, 2023 by luckman212 Link to comment
oorbx Posted February 27, 2023 Share Posted February 27, 2023 7 hours ago, luckman212 said: @oorbx and @evanfuchs - Can you try the latest version of the workflow (2.1.4) that I just published? I think the problem may have been that I previously had not enabled the "Keep File Lists" option in my Alfred preferences. With that on, I see that copying images sometimes results in a "File: xxx" type which was not previously handled by my workflow. This is a first attempt at handling both types within the same script filter. Please let me know if it works for you. it works now ! thanks a lot luckman212 1 Link to comment
evanfuchs Posted February 27, 2023 Share Posted February 27, 2023 Thanks, @luckman212. This version does seem to display the images that were missing. For some new fun, I get the following error when I select (↩) an entry: "/Users/xxx/Dropbox/Screenshots/Screen Shot 2023-01-25 at 12.51.42 PM.png", "subtitle": "from: File List"}, "cmd": {"arg": "/Users/xx [truncated] [08:08:10.137] ClipSaver[Script Filter] Processing complete [08:08:10.138] ClipSaver[Script Filter] Passing output '/Users/xxx/Dropbox/Screenshots/Screen Shot 2023-02-27 at 7.37.41 AM.png' to Conditional [08:08:10.144] ClipSaver[Conditional] Processing complete [08:08:10.145] ClipSaver[Conditional] Passing output '/Users/xxx/Dropbox/Screenshots/Screen Shot 2023-02-27 at 7.37.41 AM.png' to Run Script [08:08:10.283] ERROR: ClipSaver[Run Script] /Users/xxx/Dropbox/applications/Alfred-app/Alfred.alfredpreferences/workflows/user.workflow.36F89F80-8C20-4470-B90D-8BF94E81E85B/save_single.sh: line 26: ${save_to_current,,}: bad substitution /Users/xxx/Dropbox/applications/Alfred-app/Alfred.alfredpreferences/workflows/user.workflow.36F89F80-8C20-4470-B90D-8BF94E81E85B/save_single.sh: line 35: ${img_pathname,,}: bad substitution [08:08:10.284] ClipSaver[Run Script] Processing complete [08:08:10.284] ClipSaver[Run Script] Passing output '' to Conditional This is the only place "truncated" appeared on the output, so I didn't include the entire output here. This did not show up in the previous version output, so I am guessing that is what leads to the "bad substitution"? Let me know if you need anything further. Thanks again for your help! Link to comment
luckman212 Posted February 27, 2023 Author Share Posted February 27, 2023 @evanfuchs Hmm, looks like you're on the builtin bash3 still. I didn't expect or plan for that. Bash3 doesn't know about ${var,,} to convert to lowercase. I could use tr '[:upper:]' '[:lower:] instead, but it's a little less efficient. Do you have Homebrew installed? brew install bash5 should get things working. Link to comment
oorbx Posted February 27, 2023 Share Posted February 27, 2023 Okay, for me i can see images, but nothing is saved. just create empty folder on desktop but any format i will use, keep empty. hmm Link to comment
evanfuchs Posted February 27, 2023 Share Posted February 27, 2023 1 hour ago, luckman212 said: Do you have Homebrew installed? brew install bash5 should get things working. Updating in macOS Monterey was a little less straight forward than that for reasons that are beyond me, but I did get it updated after some googling and the workflow seems to be working. Thanks again. Link to comment
luckman212 Posted February 27, 2023 Author Share Posted February 27, 2023 I just pushed v2.2.1 which should remove the bash5 dependency and also adopts Alfred 5's more friendly Configuration panel. @oorbx if you want to test & report back... thanks Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 (edited) v2.3.0 is out. Let me know how it's working for you. Edited February 28, 2023 by luckman212 Link to comment
oorbx Posted February 28, 2023 Share Posted February 28, 2023 10 hours ago, luckman212 said: v2.3.0 is out. Let me know how it's working for you. Hey luckman, updated version found the picture in clipboard correctly but after conversion just everytime creates only empty folder on desktop "saved_clips" without anything inside. Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 @oorbx Hmm. Can you please open your debug console, press "Clear" and then run the workflow all the way through, then copy & paste all the output to a pastebin? Link to comment
evanfuchs Posted February 28, 2023 Share Posted February 28, 2023 11 hours ago, luckman212 said: v2.3.0 is out. Let me know how it's working for you. So far so good! 👍 Link to comment
oorbx Posted February 28, 2023 Share Posted February 28, 2023 2 hours ago, luckman212 said: @oorbx Hmm. Can you please open your debug console, press "Clear" and then run the workflow all the way through, then copy & paste all the output to a pastebin? https://pastebin.com/aLdWjWVj here it is Maybe its related to ventura 13.3 beta. I dont know. Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 No, I don't think it's the 13.3 beta. looking at the pastebin it seems you still have an old version of the workflow installed. Not sure why the in place upgrade didn't work, but why don't you go ahead and delete the entire workflow, download the latest one and reinstall it Let me know if that clears things up. @oorbx Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 @oorbx Actually it seems some incorrect code slipped thru. Not sure what happened but I'm away from my Mac at the moment. I'll fix it asap, sorry Link to comment
oorbx Posted February 28, 2023 Share Posted February 28, 2023 51 minutes ago, luckman212 said: No, I don't think it's the 13.3 beta. looking at the pastebin it seems you still have an old version of the workflow installed. Not sure why the in place upgrade didn't work, but why don't you go ahead and delete the entire workflow, download the latest one and reinstall it Let me know if that clears things up. @oorbx deleted completely, installed new. output folder empty 🙂 strange Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 4 minutes ago, oorbx said: deleted completely, installed new. output folder empty 🙂 strange Somehow the wrong change got committed at some point while I was removing the Bash5'isms. I'll upload a v2.3.1 soon that fixes it... Link to comment
luckman212 Posted February 28, 2023 Author Share Posted February 28, 2023 @oorbx Please give 2.3.3 a try when you have time. Thanks Link to comment
oorbx Posted March 1, 2023 Share Posted March 1, 2023 7 hours ago, luckman212 said: @oorbx Please give 2.3.3 a try when you have time. Thanks wau, finally works.. thanks Link to comment
oorbx Posted March 1, 2023 Share Posted March 1, 2023 Maybe my last question... Do you plan some extension of your plugin ? Something like argument for percentage resize, pixel resize, image flip or any other image operations ? There are a lot of plugins for that, but nothing is fully complex or updated Thanks Link to comment
luckman212 Posted March 1, 2023 Author Share Posted March 1, 2023 @oorbx Nice idea. I already have another workflow that uses imagemagick to perform some operations like that, DPI conversions, resizing, adding borders. I'll eventually try to integrate them all together in a future version, but it wouldn't be ready for a little while. Link to comment
cocoaaa Posted April 5, 2023 Share Posted April 5, 2023 Thanks for a nice workflow. I find it very useful for my note-taking system:) luckman212 1 Link to comment
seanc Posted May 2, 2023 Share Posted May 2, 2023 @luckman212 thanks so much for creating this workflow, which is such a time saver! However, I'm wondering if it would be possible to add this feature in future release: overriding default format? E.g. I trigger alfred and type "cs 4 jpg", then it saves in jpg instead of the default png. I often need to save between png & jpg. So a single default doesn't work that well for me. If you can add an optional argument that would be incredible. Link to comment
luckman212 Posted April 25 Author Share Posted April 25 I can no longer edit the top post, so just announcing here that I just pushed a small update (2.4.2) that supports Alfred 5.5's new Grid View. https://github.com/luckman212/alfred_clipsaver_workflow/releases/tag/2.4.2 Link to comment
luckman212 Posted April 26 Author Share Posted April 26 v2.5.0 has more actions that can be called from the Grid View (integrated with CleanShot), allows multi-select via File Buffer, and some additional Workflow configuration options as well such as Grid Size and trigger keyword. https://github.com/luckman212/alfred_clipsaver_workflow/releases/tag/2.5.0 Link to comment
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now